yep, nothing has changed.

If you renew when they have 1 year left on their contract, the player will sign a 3 year contract.

If you renew when the contract has expired, the player will sign a 2 year contract.

Sign the player when the contract expires because the bonus will be lower since it is based on market value.

Salary doesn't change though. He will earn the same amount in the new season if you renew him at the end of the old season or at the start of the new season.